convert everything to ESM#355
Merged
Merged
Conversation
Merged
* fix(test): manually control `UVU_QUEUE` positions; Have to replicate the `uvu` internals since all internal loader/iterator logic is bypassed. * fix: force `UVU_QUEUE` values * chore: add `context.reset` method; - chasing unterminated process * fix(kit): return `snowpack.shutdown` promise - so that `dev.close` is await'able * fix(runner): manually exit process; - also part of what uvu cli does; derp * chore: convert "test/apps/basics" fixture * chore: convert "test/apps/options" fixture
Member
meriyah 4.1.1 is out now (though I'm having some trouble using it. I haven't tried it with this PR though) |
Member
|
I found another issue related to this. In the |
Member
Author
benmccann
reviewed
Feb 10, 2021
Member
Author
|
the |
Merged
benmccann
pushed a commit
that referenced
this pull request
Feb 10, 2021
* start converting everything to ESM * more stuff * chore: finish ESM conversion (#360) * fix(test): manually control `UVU_QUEUE` positions; Have to replicate the `uvu` internals since all internal loader/iterator logic is bypassed. * fix: force `UVU_QUEUE` values * chore: add `context.reset` method; - chasing unterminated process * fix(kit): return `snowpack.shutdown` promise - so that `dev.close` is await'able * fix(runner): manually exit process; - also part of what uvu cli does; derp * chore: convert "test/apps/basics" fixture * chore: convert "test/apps/options" fixture * bump meriyah * all tests passing, i think? * simplify * get CLI working * brute force Co-authored-by: Luke Edwards <luke.edwards05@gmail.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#349.
Most stuff doesn't work yet. The
app-utilstests are passing, but thekitunit tests won't at least until the new version of Meriyah is released.The integration tests in
testdon't work, because I haven't been able to get uvu to work with tests that are loaded asynchronously (cc @lukeed). The simplest way to see this is tocd test/apps/amp(after updating dependencies) andpnpm test: